Attention is currently required from: Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki, Raul Rangel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75451?usp=email )
Change subject: soc/amd/block/ivrs: Generalize IVRS table generation
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/common/block/acpi/ivrs.c:
https://review.coreboot.org/c/coreboot/+/75451/comment/83c9cd0b_8e58769c :
PS7, Line 262: /* Find EMMC */
: if (!nb_dev->bus)
: dev = pcidev_path_behind(nb_dev->bus, PCI_DEVFN(0x13, 1));
Previously, the entry was added without any conditions.
It seems that the assumption was made that it is always present.
However, based on my understanding, this entry should only be relevant if the device is present.
I'm uncertain if adding it without any conditions would be appropriate.
Please let me know your thoughts. Will align it accordingly.
Thanks.
I don't see any 13.1 device present on any AMD devicetree. I'm not sure if D0x13,F0x1 has any meaning. I guess keeping the behavior to unconditionally add it is the way to go?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75451?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic471f05d6000c21081d70495b7dbd4350e68b774
Gerrit-Change-Number: 75451
Gerrit-PatchSet: 7
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 07 Jun 2023 07:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-MessageType: comment