Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11049
-gerrit
commit 1ab03d1b2829cad0eb6ff7258376ac171a67639b Author: Stefan Reinauer stefan.reinauer@coreboot.org Date: Tue Jul 14 12:07:56 2015 -0700
tegra210: Fix parameter order of write32()
The correct function prototype is
void write32(void *addr, uint32_t val)
BUG=chrome-os-partner:38073 BRANCH=none TEST=build lp0 code and see it succeed. Signed-off-by: Stefan Reinauer reinauer@chromium.org
Change-Id: Icadc9e2d142e5a222509e894f43b0c8a70eed031 Signed-off-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Id: b46635d9d3ee1ca364e7ad6d6dd7ea9efa9dedbc Original-Change-Id: Id2b6847af80dfddcb3b7133a663becb78ed477ba Original-Reviewed-on: https://chromium-review.googlesource.com/285544 Original-Reviewed-by: Furquan Shaikh furquan@chromium.org Original-Reviewed-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Queue: Stefan Reinauer reinauer@chromium.org Original-Tested-by: Stefan Reinauer reinauer@chromium.org --- src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c index cf9c212..fdd25dd 100644 --- a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c +++ b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c @@ -413,7 +413,7 @@ static inline uint32_t read32(const void *addr) return *(volatile uint32_t *)addr; }
-static inline void write32(uint32_t val, void *addr) +static inline void write32(void *addr, uint32_t val) { *(volatile uint32_t *)addr = val; }