Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 10: 3
Is this true for all platforms? I think there should not be any default here and instead the platfor […]
Prefer this stays 3, since all the current platforms have 3 and as said earlier this is not going to change soon.
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 781: partition_id != BP1 && partition_id != BP2
So, BP1 and BP2 are fine but not BP3? Why?
The BP contents can be basically categorized as below. BP1 - Recovery/minimal boot FW BP2 - Minimal boot FW + Some CSME FW modules. BP2 - other CSME FW modules
BP1 and BP2 are the only bootable partitions in Client systems. BP3 content has be loaded by BP2, not bootable on its own.
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 167: partition_fw_version
How does this relate to the fw version that is currently decoded by each SoC driver? e.g. […]
The structures are same, moving to common is part of another patch. which will be restored once all the current train is merged. see https://review.coreboot.org/c/coreboot/+/35230
-
Rizwan Qureshi (Code Review)