Change in coreboot[master]: src/lib: Support fallback option for fw_config

Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Subrata Banik, Julius Werner, Nick Vaccaro, Raj Astekar, Srinidhi N Kaushik. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58833 ) Change subject: src/lib: Support fallback option for fw_config ...................................................................... Patch Set 5: (2 comments) File src/lib/fw_config.c: https://review.coreboot.org/c/coreboot/+/58833/comment/eec412bc_63e4d425 PS5, Line 31: fw_config_value = UNDEFINED_FW_CONFIG; this line is now redundant https://review.coreboot.org/c/coreboot/+/58833/comment/2662c0a3_3478e397 PS5, Line 43: fw_config_value = UNDEFINED_FW_CONFIG; also redundant -- To view, visit https://review.coreboot.org/c/coreboot/+/58833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I215c13a4fcb9dc3b94f73c770e704d4e353e9cff Gerrit-Change-Number: 58833 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh@gmail.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu@intel.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh@gmail.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu@intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> Gerrit-Attention: Subrata Banik <subrata.banik@intel.com> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro@google.com> Gerrit-Attention: Raj Astekar <raj.astekar@intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> Gerrit-Comment-Date: Wed, 03 Nov 2021 14:20:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
Tim Wawrzynczak (Code Review)