Attention is currently required from: Jian Tong, Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: lotso: Add hid report address for gt7986u
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/spi/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/83139/comment/487e4765_54b566e8?usp... :
PS3, Line 151: /* Add generic property list */
: acpi_dp_add_property_list(dsd, config->property_list,
: config->property_count);
Nit: Please add one more tab to the indentation.
Done
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83139/comment/b1f7af60_6410d715?usp... :
PS3, Line 374: register "property_count" = "1"
: register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
: register "property_list[0].name" = ""goodix,hid-report-addr""
: register "property_list[0].integer" = "0x22c8c"
Keep this mainboard change in a separate CL.
I will submit a separate CL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 4
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 02:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com