Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56604 )
Change subject: ec/roda/it8518/acpi: Get rid of `Index()` ......................................................................
ec/roda/it8518/acpi: Get rid of `Index()`
Use `FOOO[1337]` instead of `Index(FOOO, 1337)`.
Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the same.
Change-Id: I4f5d5cb8ce8c3ae37dc44ca87bd67596af9feee8 Signed-off-by: Felix Singer felix.singer@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/56604 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/roda/it8518/acpi/battery.asl 1 file changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/ec/roda/it8518/acpi/battery.asl b/src/ec/roda/it8518/acpi/battery.asl index 12295a2..2859fce 100644 --- a/src/ec/roda/it8518/acpi/battery.asl +++ b/src/ec/roda/it8518/acpi/battery.asl @@ -62,9 +62,9 @@ { Printf ("-----> BAT0: _BIF")
- Store (B0FC, Index (PBIF, 2)) - Store (Divide (Multiply (B0FC, 6), 100), Index (PBIF, 5)) - Store (Divide (Multiply (B0FC, 3), 100), Index (PBIF, 6)) + Store (B0FC, PBIF[2]) + Store (Divide (Multiply (B0FC, 6), 100), PBIF[5]) + Store (Divide (Multiply (B0FC, 3), 100), PBIF[6])
Printf ("<----- BAT0: _BIF")
@@ -81,16 +81,16 @@ { If (LEqual (PWRS, 1)) { - Store (0x00, Index (PBST, 0)) + Store (0x00, PBST[0]) } Else { - Store (0x01, Index (PBST, 0)) + Store (0x01, PBST[0]) } } Else { - Store (0x02, Index (PBST, 0)) + Store (0x02, PBST[0]) }
Store (B0AC, Local1) @@ -99,9 +99,9 @@ Subtract (0x00010000, Local1, Local1) }
- Store (Local1, Index (PBST, 1)) - Store (B0RC, Index (PBST, 2)) - Store (B0VT, Index (PBST, 3)) + Store (Local1, PBST[1]) + Store (B0RC, PBST[2]) + Store (B0VT, PBST[3])
Printf ("<----- BAT0: _BST")