Change in coreboot[master]: src/mainboard/up/squared: Fix VBOOT on Up Squared

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Christian Walter (Code Review)

19 Jul 2019 19 Jul '19

5:31 a.m.

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

src/mainboard/up/squared: Fix VBOOT on Up Squared

Fix VBOOT on UP Squared thanks to previous VBOOT Patch.

Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/up/squared/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34452/1

diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index 59bd2ce..fc3c2f5 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -17,6 +17,7 @@

config VBOOT select VBOOT_NO_BOARD_SUPPORT + select VBOOT_MAY_SKIP_DISPLAY_INIT select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Paul Menzel (Code Review)

22 Jul 22 Jul

8:22 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG@9 PS4, Line 9: Fix What is broken? Please elaborate in the commit message.

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG@9 PS4, Line 9: Patch patch

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 4 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 22 Jul 2019 15:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

9:25 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34452

to look at the new patch set (#7).

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

src/mainboard/up/squared: Fix VBOOT on Up Squared

Fix VBOOT on UP Squared thanks to previous VBOOT Patch. We need to select VBOOT_MAY_SKIP_DISPLAY_INIT, otherwise the build will fail.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34452/7

Christian Walter (Code Review)

9:26 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34452

to look at the new patch set (#8).

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

src/mainboard/up/squared: Fix VBOOT on Up Squared

Fix VBOOT on UP Squared thanks to previous VBOOT patch. We need to select VBOOT_MAY_SKIP_DISPLAY_INIT, otherwise the build will fail.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34452/8

Christian Walter (Code Review)

9:26 a.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 8:

(2 comments)

...

Patch Set 4:

(2 comments)

If you

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG@9 PS4, Line 9: Patch

...

patch

Ack

https://review.coreboot.org/c/coreboot/+/34452/4//COMMIT_MSG@9 PS4, Line 9: Fix

...

What is broken? Please elaborate in the commit message.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 8 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 22 Jul 2019 16:26:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Christian Walter (Code Review)

23 Jul 23 Jul

2:26 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34452

to look at the new patch set (#9).

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

src/mainboard/up/squared: Fix VBOOT on Up Squared

Fix VBOOT on UP Squared thanks to previous VBOOT Patch.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34452/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Christian Walter (Code Review)

26 Jul 26 Jul

7:50 a.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jul 2019 14:50:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Christian Walter (Code Review)

8:03 a.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 9: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jul 2019 15:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

8:16 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 9:

seems to be used on chromeos only. I don't see how the previous patch should affect UP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jul 2019 15:16:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

29 Jul 29 Jul

12:44 a.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Patch Set 9:

...

Patch Set 9:

seems to be used on chromeos only. I don't see how the previous patch should affect UP.

You might be right. You have to select this, if you select SeaBIOS with VGA legacy ROM.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jul 2019 07:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

12:45 a.m.

Christian Walter has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34452 )

Change subject: src/mainboard/up/squared: Fix VBOOT on Up Squared ......................................................................

Abandoned

SeaBIOS-specific - sorry.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ee57f09374c938fa31dae5dc3df03fdac153c77 Gerrit-Change-Number: 34452 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1937

days inactive

1947

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Christian Walter (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)