Attention is currently required from: Alexey Buyanov, Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Nikolai Vyssotski, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61311 )
Change subject: console: Add IO port serial logging
......................................................................
Patch Set 5:
(4 comments)
File src/arch/x86/include/arch/io.h:
https://review.coreboot.org/c/coreboot/+/61311/comment/a3708577_151dc03e
PS5, Line 8: 0x5f535452ul
This is really a SIMNow sentinel value. I don't think it belongs with common arch/io
File src/arch/x86/post.c:
https://review.coreboot.org/c/coreboot/+/61311/comment/7e02c43a_613fd4f2
PS5, Line 10: if (CONFIG(CONSOLE_AMD_IO_PORT))
: outl(AMD_IO_PORT_DATA_END, CONFIG_POST_IO_PORT);
Instead of modifying the common code, can we modify the simnow_tx_byte method to write the BEGIN byte, character byte, then END byte. Sure it will be slow, but simnow is already slow. This will keep the default ioport write working and hide all the simnow complexity.
File src/include/console/io_port.h:
PS5:
Can we rename this to simnow.h?
File src/soc/amd/sabrina/bootblock.c:
https://review.coreboot.org/c/coreboot/+/61311/comment/d2f247af_b5bd4158
PS5, Line 39: if (CONFIG(CONSOLE_AMD_IO_PORT))
: outl(AMD_IO_PORT_DATA_BEGIN, CONFIG_POST_IO_PORT);
This should be done as part of the console_init
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87afea28535e03ef39e104e353255a901015973b
Gerrit-Change-Number: 61311
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Buyanov
al3xbuy@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexey Buyanov
alexey.buyanov@amd.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexey Buyanov
al3xbuy@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 22 Apr 2022 15:28:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment