Change in coreboot[master]: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
Change-Id: I0c8ff9ab125129dc856949c47a3a0c14e4109c73 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/devicetree.cb M src/soc/amd/picasso/chip.h 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/43417/1
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb index 97022c5..f83a634 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb @@ -4,7 +4,6 @@ register "acp_pin_cfg" = "I2S_PINS_MAX_HDA"
# Set FADT Configuration - register "fadt_pm_profile" = "PM_UNSPECIFIED" register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "fadt_flags" = "ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree.cb b/src/mainboard/google/zork/variants/baseboard/devicetree.cb index ca33bbd..00c574c 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree.cb @@ -2,7 +2,6 @@ chip soc/amd/picasso
# Set FADT Configuration - register "fadt_pm_profile" = "PM_MOBILE" register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "fadt_flags" = "ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 205733a..1d3ee9d 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -74,7 +74,6 @@ struct acpi_gpio dmic_select_gpio;
/* Options for these are in src/arch/x86/include/acpi/acpi.h */ - uint8_t fadt_pm_profile; uint16_t fadt_boot_arch; uint32_t fadt_flags;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43417
to look at the new patch set (#2).
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
Change-Id: I0c8ff9ab125129dc856949c47a3a0c14e4109c73 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/soc/amd/picasso/chip.h 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/43417/2
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43417
to look at the new patch set (#3).
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
Change-Id: I0c8ff9ab125129dc856949c47a3a0c14e4109c73 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/soc/amd/picasso/chip.h 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/43417/3
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43417
to look at the new patch set (#4).
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
commit 56da63c3dc3f50cfac541c779b608e1bae9e635c removed overriding that field in the FADT.
Change-Id: I0c8ff9ab125129dc856949c47a3a0c14e4109c73 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/soc/amd/picasso/chip.h 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/43417/4
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
Patch Set 4: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43417 )
Change subject: soc/amd/picasso: remove unused fadt_pm_profile devicetree setting ......................................................................
soc/amd/picasso: remove unused fadt_pm_profile devicetree setting
commit 56da63c3dc3f50cfac541c779b608e1bae9e635c removed overriding that field in the FADT.
Change-Id: I0c8ff9ab125129dc856949c47a3a0c14e4109c73 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43417 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/soc/amd/picasso/chip.h 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb index 97022c5..f83a634 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb @@ -4,7 +4,6 @@ register "acp_pin_cfg" = "I2S_PINS_MAX_HDA"
# Set FADT Configuration - register "fadt_pm_profile" = "PM_UNSPECIFIED" register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "fadt_flags" = "ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb index 10d86c3..6452e60 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb @@ -2,7 +2,6 @@ chip soc/amd/picasso
# Set FADT Configuration - register "fadt_pm_profile" = "PM_MOBILE" register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "fadt_flags" = "ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 585f5a7..5132b18 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -2,7 +2,6 @@ chip soc/amd/picasso
# Set FADT Configuration - register "fadt_pm_profile" = "PM_MOBILE" register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "fadt_flags" = "ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 205733a..1d3ee9d 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -74,7 +74,6 @@ struct acpi_gpio dmic_select_gpio;
/* Options for these are in src/arch/x86/include/acpi/acpi.h */ - uint8_t fadt_pm_profile; uint16_t fadt_boot_arch; uint32_t fadt_flags;
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)