[S] Change in coreboot[main]: mb/google/fatcat: support ISH - coreboot-gerrit

30 Oct 2024


      Attention is currently required from: Bora Guvendik, Cliff Huang, Hannah Williams, Li1 Feng, Pranava Y N, Subrata Banik, Tanu Malhotra.
Jérémy Compostella has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84739?usp=email )
Change subject: mb/google/fatcat: support ISH
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84739/comment/451f9e22_3f89dc47?usp... :
PS3, Line 302: 		device ref pcie_rp2 on
nit: missing empty line
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84739?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b6eb39fe7b07fcabc255d66df4aa0aa2865df79
Gerrit-Change-Number: 84739
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Li1 Feng li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tanu Malhotra tanu.malhotra@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bora Guvendik bora.guvendik@intel.corp-partner.google.com
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tanu Malhotra tanu.malhotra@intel.com
Gerrit-Attention: Li1 Feng li1.feng@intel.com
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 16:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes