Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, V Sowmya, Vidya Gopalakrishnan, Vinay Kumar.
Paul Menzel has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/trulo: Remove overriding of PL1 value to 20W
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85184/comment/08cbbf8b_6b8c93cc?usp... :
PS5, Line 9: The RAPL PL1 limit and MMIO PL1 max values should be set as per
: silicon TDP (6W for N150/N250, 15W for N355).
According to whom?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I798c4f10e10a579f470e00dbdb77a84619ad796a
Gerrit-Change-Number: 85184
Gerrit-PatchSet: 5
Gerrit-Owner: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Comment-Date: Fri, 22 Nov 2024 16:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes