Attention is currently required from: Nicholas Chin, Nicholas Sudsgaard, Nico Huber.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80695/comment/5ffd9520_0a4baf8c :
PS3, Line 15: - All enum names now use the `AZALIA_` prefix.
what for? I would rather remove it
Patchset:
PS3:
Thank you for cleaning that up!
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/2b962719_d4910f21 :
PS3, Line 85: = 0x2,
It's a enum, do we really want to have explicit values here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80695?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e
Gerrit-Change-Number: 80695
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 24 Feb 2024 09:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment