Attention is currently required from: V Sowmya, Sugnan Prabhu S, Rizwan Qureshi, Aamir Bohra, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51274 )
Change subject: soc/intel/alderlake/acpi: Skip D3Cold for TBT
......................................................................
Patch Set 3: -Code-Review
(1 comment)
Patchset:
PS3:
Taking back +2 as i think we need to understand in details by D3 cold need t skip for a controller when device is not attached to it. Ideally IP FW should be enough to say i don't have device and i don't take part of system PM. I know some reason why this was skipped during early PO but shouldn't be applicable now. This is most likely some bug where device not attached with TBT is still acting and blocking S0ix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b9ceee4393aeba37fdcb4e05d1b279a6ff72d2
Gerrit-Change-Number: 51274
Gerrit-PatchSet: 3
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 25 Mar 2021 10:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment