[XS] Change in coreboot[master]: mb/google/myst/bootblock.c: Initialize spi flash - coreboot-gerrit

6 Jun 2023


      Attention is currently required from: Felix Held, Fred Reitberger, Martin L Roth.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75588?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/myst/bootblock.c: Initialize spi flash
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/myst/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75588/comment/fd6ad726_6efcdf6f :
PS1, Line 41: 	// b:285110121 - temp workaround is to add a dummy flash call
Can you add "TODO" so it's easier to grep for this?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75588?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia88d2b46884b096b4c558bc86513159ec6d35eb5
Gerrit-Change-Number: 75588
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 20:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment