Change in coreboot[master]: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44521 )

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number

Change-Id: I793afe81fbb9abef0d4178af9dc2e91c612b1b43
Signed-off-by: Elyes HAOUAS 
---
M src/southbridge/intel/i82371eb/fadt.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/44521/1

diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 9abe48c..655f83a 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -101,7 +101,8 @@
     * 18   FORCE_APIC_CLUSTER_MODEL
     * 19   FORCE_APIC_PHYSICAL_DESTINATION_MODE
     */
-	fadt->flags |= 0xa5;
+	fadt->flags |= (ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED | ACPI_FADT_SLEEP_BUTTON |
+			ACPI_FADT_S4_RTC_WAKE);

fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44521 )

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237... 
File src/southbridge/intel/i82371eb/fadt.c:

https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237... 
PS1, Line 104: (
no need for parens

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44521

to look at the new patch set (#2).

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number

Change-Id: I793afe81fbb9abef0d4178af9dc2e91c612b1b43
Signed-off-by: Elyes HAOUAS 
---
M src/southbridge/intel/i82371eb/fadt.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/44521/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44521 )

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237... 
File src/southbridge/intel/i82371eb/fadt.c:

https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237... 
PS1, Line 104: (
> no need for parens

Thank you.

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44521 )

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44521 )

Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................

sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number

Change-Id: I793afe81fbb9abef0d4178af9dc2e91c612b1b43
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44521
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/i82371eb/fadt.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 5add01c..5aeff4e 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -102,7 +102,8 @@
     * 18   FORCE_APIC_CLUSTER_MODEL
     * 19   FORCE_APIC_PHYSICAL_DESTINATION_MODE
     */
-	fadt->flags |= 0xa5;
+	fadt->flags |= ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED | ACPI_FADT_SLEEP_BUTTON |
+		       ACPI_FADT_S4_RTC_WAKE;

fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;