Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, Paul Menzel, Saurabh Mishra, Wonkyu Kim.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83981?usp=email )
Change subject: soc/intel/common/gpio: support 16-bit CPU Port ID
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83981/comment/1940d3d7_c468cc4e?usp... :
PS4, Line 13: vw_index and position are not continuous in between groups within a
: community.
I don't see these vw_index and bit position in EDS. I can provide a brief info here to help understand the existing code for vw_index and position calculation and the purpose of this CL change:
VW index bit position
com0:
GPP_C_00: 10h 0 <- base is 0x10 for the community
...
GPP_C_07: 10h 7
GPP_C_08: 11h 0
...
GPP_C_23: 12h 7
com1:
GPP_F_00: 10h 0 <- base is 0x10 for the community
...
GPP_F_23: 12h 7
GPP_E_00: 13h 0
...
GPP_E_22: 15h 6
com3:
GPP_A_00: 10h 0 <- base is 0x10 for the community
...
GPP_A_17: 12h 1
GPP_H_00: 13h 0 <- previous positon is 1, but start from 0
...
GPP_H_24: 16h 0
com5:
GPP_B_00: 10h 3 <- bit position not 0
...
GPP_B_25: 13h 1
GPP_D_00: 14h 0 <- previous position is 1, skip to start from 0
...
GPP_D_25: 17h 1
can you please ask EDS owner to add this section ? Need to understand this better. I'm still unable to follow what does start_pos refers to in PTL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83981?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c1a48d587bd41178b0c6bb0144fda93e292423d
Gerrit-Change-Number: 83981
Gerrit-PatchSet: 7
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 20 Aug 2024 18:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com