Attention is currently required from: Pranava Y N, Subrata Banik, Weimin Wu.
Paul Menzel has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email )
Change subject: mb/google/fatcat/var/felino: Modify devicetree for ALC712 codec
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85572/comment/36448507_40dadf55?usp... :
PS2, Line 7: Modify devicetree for ALC712 codec
Maybe:
Add ALC712 codec to devicetree
https://review.coreboot.org/c/coreboot/+/85572/comment/1b0aacbd_c723c95d?usp... :
PS2, Line 10:
Please add, where you got the devicetree values, like `bus_frequency_configs`, from.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df
Gerrit-Change-Number: 85572
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Thu, 12 Dec 2024 14:20:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No