[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Delay to deassert RST pin for TCHSCR

[Varshit Pandya (Code Review)]

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu.

Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81636?usp=email )

Change subject: mb/google/nissa/var/anraggar: Delay to deassert RST pin for TCHSCR
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81636/comment/2393982d_c216fa4e :
PS2, Line 8: 
If I understand your change correctly, you are trying to introduce a delay in the rising of GPP_C1 and also configure GPP_C0 (enable pin to 1), if so I would reword the commit message to

====================================================

mb/google/nissa/var/anraggar: Configure touchscreen related GPIOs

GPP_C1 is connected to reset pin of touchscreen module, to comply with
specification of having a delay of at least 10ms for module to reset,
assert GPP_C1 in early_gpio_table and de-assert it in
override_gpio_table.

GPP_C0 is connected to enable pin of touchscreen module, configure it to
1 in override_gpio_table once the module is out of reset.

BUG=b:314744757
TEST=Build, Boot anraggar board and check touchscreen working

======================================================

Please ignore this comment if I have not understood the bug correctly

https://review.coreboot.org/c/coreboot/+/81636/comment/c1e0de02_21739b4b :
PS2, Line 9: touchscree
touchscreen

https://review.coreboot.org/c/coreboot/+/81636/comment/3efd17a9_42dbf13e :
PS2, Line 11:  SPEC requirements.
It would be good if you could mention the spec which you are referring to and the version of that spec.

https://review.coreboot.org/c/coreboot/+/81636/comment/f49423db_f0e53379 :
PS2, Line 13: BUG=314744757
"BUG=b:314744757" ?