Attention is currently required from: Cliff Huang, Martin Roth, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55259 )
Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
......................................................................
Patch Set 20:
(2 comments)
File util/cbfstool/cse_fpt.h:
https://review.coreboot.org/c/coreboot/+/55259/comment/21849ba0_eb44b764
PS17, Line 14: r
tab after `)`
Done
File util/cbfstool/cse_fpt.c:
https://review.coreboot.org/c/coreboot/+/55259/comment/c6107032_5088be6b
PS17, Line 2: /* SPDX-License-Identifier: GPL-2.0-only */
nit: should this go on the first line?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6
Gerrit-Change-Number: 55259
Gerrit-PatchSet: 20
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrew McRae
amcrae@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Andrew McRae
amcrae@google.com
Gerrit-Comment-Date: Fri, 08 Oct 2021 22:23:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment