Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Hsuan-ting Chen, Tim Wawrzynczak, Bernardo Perez Priego. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/adlrvp: Add hook function to return EC in RW status ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58099/comment/a044bc5d_5ac30d3d PS7, Line 7: mb/adlrvp mb/intel/adlrvp
https://review.coreboot.org/c/coreboot/+/58099/comment/6ef8026d_ec33a488 PS7, Line 11: un trusted untrusted
https://review.coreboot.org/c/coreboot/+/58099/comment/6a74b6f9_c77cf0ac PS7, Line 9: EC_IN_RW signal from EC GPIO is connected to GPIO E7 : of SOC. The function reads this GPIO to check if EC is in : RW (un trusted) or RO (trusted) Please reflow for 75 characters per line, and please add a dot/period to the end of sentences.
File src/mainboard/intel/adlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58099/comment/2f8028cf_3b0f82b1 PS7, Line 51: int bool or unsigned int?
File src/mainboard/intel/adlrvp/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/58099/comment/7f5bdc25_a16977ca PS7, Line 15: #define GPIO_EC_IN_RW GPP_E7 Please align with a tabs as done above.