Change in coreboot[master]: drivers/amd/agesa/romstage.c: Remove lapic_id check - coreboot-gerrit

11 Nov 2021


      Attention is currently required from: Arthur Heymans, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55065 )
Change subject: drivers/amd/agesa/romstage.c: Remove lapic_id check
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55065/comment/24635c81_46977224 
PS3, Line 9: The APs don't execute this codepath but ap_romstage_main().
So, if I understand correctly, `romstage_main()` is only executed by the BSP. Does the BSP always have an initial LAPIC ID of 0? I guess so, otherwise the original code would have problems.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If884001bc8c5363efbbf00422a9a700896318f7b
Gerrit-Change-Number: 55065
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-CC: Mike Banon mikebdp2@gmail.com
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment