Attention is currently required from: Caveh Jalali, Daisuke Nojiri, Karthik Ramasubramanian, Nick Vaccaro, Paul Menzel, Shelley Chen.
Pavan Holla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
Change subject: ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled
......................................................................
Patch Set 11:
(1 comment)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/81967/comment/7722052a_0f074f8a :
PS2, Line 435: int
Functions called within google_chromeec_get_ucsi_enabled return int as well. […]
Changed to bool because ec_acpi.c looks better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81967?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67dff6445aa7ba3ba48a04d1df3541f880d09d0a
Gerrit-Change-Number: 81967
Gerrit-PatchSet: 11
Gerrit-Owner: Pavan Holla
pholla@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Forest Mittelberg
bmbm@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 22:27:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pavan Holla
pholla@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment