Attention is currently required from: HAOUAS Elyes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60616 )
Change subject: src/superio/smsc: Remove unused <stdlib.h>
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/superio/smsc/sch5545/superio.c:
https://review.coreboot.org/c/coreboot/+/60616/comment/cf8d668b_611aa551
PS3, Line 9: #include <stdlib.h>
maybe just <stdint.h> […]
ok, types.h should be added as include then. i'm ok with doing that in a separate patch; just mark this comment as done when you've pushed a patch for this to gerrit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb747bcb702a81750a927272432666ffe603ca55
Gerrit-Change-Number: 60616
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 04 Jan 2022 17:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment