Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186 ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84342/comment/a119e67e_6a154a66?usp... : PS2, Line 7: Make compatible with MT8186T by modifing skuid
Distinguish MT8186T's SKU ID from MT8186
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/81a41919_077c218d?usp... : PS2, Line 9: skuid
SKU ID
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/63ff905d_12e0c0f5?usp... : PS2, Line 10: corresponded
corresponding
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/51e6a038_735a9f53?usp... : PS2, Line 11: coreboot will pass skuid to kernel by 0x7ffffffe, : so kernel can get the corresponded dts file for system boot.
change the SKU ID to 0x7ffffffe, so that the correct dts file will be selected by the payload.
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/f65b33c4_8cd1f608?usp... : PS2, Line 15: 1.Pre-flashed 0x7fffffff and boot OS. : 2.Check OS boot normally by 0x7ffffffe.
It’d be great if you put a space after the “bullet”.
Done
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/d6ed142d_8b2b4372?usp... : PS2, Line 16: /* Define compatible sku_id value */
remove
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/8720ae74_d7922cf2?usp... : PS2, Line 17: CROS_SKU_COM
CROS_SKU_UNPROVISIONED_MT8186T
Done