HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
payloads: Fix typos
Change-Id: Ib7f1ba1766e5c972542ce7571a8aa3583c513823 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M payloads/coreinfo/cpuinfo_module.c M payloads/libpayload/drivers/i8042/keyboard.c M payloads/libpayload/drivers/serial/ipq40xx.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/serial/qcs405.c M payloads/libpayload/drivers/udc/dwc2.c M payloads/libpayload/drivers/usb/dwc2.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/drivers/usb/usbhub.c M payloads/libpayload/drivers/usb/usbmsc.c M payloads/libpayload/drivers/video/graphics.c 13 files changed, 22 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38911/1
diff --git a/payloads/coreinfo/cpuinfo_module.c b/payloads/coreinfo/cpuinfo_module.c index 94379f3..2b833a9 100644 --- a/payloads/coreinfo/cpuinfo_module.c +++ b/payloads/coreinfo/cpuinfo_module.c @@ -233,7 +233,7 @@ }
if (cpu_khz != 0) - mvwprintw(win, row++, 1, "CPU Speed: %d Mhz", cpu_khz / 1000); + mvwprintw(win, row++, 1, "CPU Speed: %d MHz", cpu_khz / 1000); else mvwprintw(win, row++, 1, "CPU Speed: Error");
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index 79455cf..4ddf99d 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -353,7 +353,7 @@ */ ret = keyboard_cmd(I8042_KBCMD_SET_DEFAULT); if (!ret) { - printf("ERROR: Keyboard set default params failed!\n"); + printf("ERROR: Keyboard set default parameters failed!\n"); return ret; }
diff --git a/payloads/libpayload/drivers/serial/ipq40xx.c b/payloads/libpayload/drivers/serial/ipq40xx.c index 7656ad7..709f169 100644 --- a/payloads/libpayload/drivers/serial/ipq40xx.c +++ b/payloads/libpayload/drivers/serial/ipq40xx.c @@ -442,7 +442,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -550,7 +550,7 @@ static struct console_input_driver consin = {}; static struct console_output_driver consout = {};
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity sake let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/serial/ipq806x.c b/payloads/libpayload/drivers/serial/ipq806x.c index 183ada6..0a62149 100644 --- a/payloads/libpayload/drivers/serial/ipq806x.c +++ b/payloads/libpayload/drivers/serial/ipq806x.c @@ -235,7 +235,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ static unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -340,7 +340,7 @@ return byte; }
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity sake let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/serial/qcs405.c b/payloads/libpayload/drivers/serial/qcs405.c index 06ec5b9..d6151d2 100644 --- a/payloads/libpayload/drivers/serial/qcs405.c +++ b/payloads/libpayload/drivers/serial/qcs405.c @@ -434,7 +434,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -538,7 +538,7 @@ return byte; }
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity sake let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c index e95eb79..f8a15e2 100644 --- a/payloads/libpayload/drivers/udc/dwc2.c +++ b/payloads/libpayload/drivers/udc/dwc2.c @@ -253,7 +253,7 @@
usb_debug("dwc2_halt_ep ep %d-%d\n", ep, in_dir); depctl.d32 = readl(&ep_reg->depctl); - /*Alread disabled*/ + /*Already disabled*/ if (!depctl.epena) return; /* First step: disable EP */ @@ -558,7 +558,7 @@ writel(DXEPINT_AHBERR, &ep->ep_regs->depint); }
- /* Handle Setup Phase Done (Contorl Ep) */ + /* Handle Setup Phase Done (Control Ep) */ if (depint.setup) { usb_debug("DEPINT_SETUP\n"); writel(DXEPINT_SETUP, &ep->ep_regs->depint); diff --git a/payloads/libpayload/drivers/usb/dwc2.c b/payloads/libpayload/drivers/usb/dwc2.c index 963ae84..eef486b 100644 --- a/payloads/libpayload/drivers/usb/dwc2.c +++ b/payloads/libpayload/drivers/usb/dwc2.c @@ -233,7 +233,7 @@ packet_size = ep->maxpacketsize; packet_cnt = ALIGN_UP(size, packet_size) / packet_size; inpkt_length = packet_cnt * packet_size; - /* At least 1 packet should be programed */ + /* At least 1 packet should be programmed */ packet_cnt = (packet_cnt == 0) ? 1 : packet_cnt;
/* diff --git a/payloads/libpayload/drivers/usb/ehci.c b/payloads/libpayload/drivers/usb/ehci.c index 6876340..1cfa8bb 100644 --- a/payloads/libpayload/drivers/usb/ehci.c +++ b/payloads/libpayload/drivers/usb/ehci.c @@ -78,7 +78,7 @@ usb_debug("+===================================================+\n"); usb_debug("| ############# EHCI QH at [0x%08lx] ########### |\n", virt_to_phys(cur)); usb_debug("+---------------------------------------------------+\n"); - usb_debug("| Horizonal Link Pointer [0x%08lx] |\n", cur->horiz_link_ptr); + usb_debug("| Horizontal Link Pointer [0x%08lx] |\n", cur->horiz_link_ptr); usb_debug("+------------------[ 0x%08lx ]-------------------+\n", cur->epchar); usb_debug("| | Maximum Packet Length | [%04ld] |\n", ((cur->epchar & (0x7ffUL << 16)) >> 16)); usb_debug("| | Device Address | [%ld] |\n", cur->epchar & 0x7F); @@ -133,7 +133,7 @@ { short count = 0; ehci_stop(controller); - /* wait 10 ms just to be shure */ + /* wait 10 ms just to be sure */ mdelay(10); if (EHCI_INST(controller)->operation->usbsts & HC_OP_HC_HALTED) { EHCI_INST(controller)->operation->usbcmd = HC_OP_HC_RESET; @@ -215,7 +215,7 @@ total_len += page_len;
while (page_no < 5) { - /* we have a continguous mapping between virtual and physical memory */ + /* we have a contiguous mapping between virtual and physical memory */ page += 4096;
td->bufptrs[page_no++] = page; diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index f1dc081..2571273 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -66,7 +66,7 @@ usb_debug("|:| C | Condition Code | [%02ld] |:|\n", (cur->config & (0xFUL << 28)) >> 28); usb_debug("|:| O | Direction/PID | [%ld] |:|\n", (cur->config & (3UL << 19)) >> 19); usb_debug("|:| N | Buffer Rounding | [%ld] |:|\n", (cur->config & (1UL << 18)) >> 18); - usb_debug("|:| F | Delay Intterrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); + usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); usb_debug("|:| I | Data Toggle | [%ld] |:|\n", (cur->config & (3UL << 24)) >> 24); usb_debug("|:| G | Error Count | [%ld] |:|\n", (cur->config & (3UL << 26)) >> 26); usb_debug("|:+-----------------------------------------------+:|\n"); @@ -879,7 +879,7 @@ intrq_td_t *const td = INTRQ_TD_FROM_TD(done_td); intr_queue_t *const intrq = td->intrq; /* Check if the corresponding interrupt - queue is still beeing processed. */ + queue is still being processed. */ if (intrq->destroy) { /* Free this TD, and */ free(td); diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index 4004def..d98fd9e 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -499,7 +499,7 @@ break; }
- /* Gather up all endpoints belonging to this inteface */ + /* Gather up all endpoints belonging to this interface */ dev->num_endp = 1; for (; ptr + 2 <= end && ptr[0] && ptr + ptr[0] <= end; ptr += ptr[0]) { if (ptr[1] == DT_INTF || ptr[1] == DT_CFG || @@ -654,7 +654,7 @@ controller->devices[devno]->configuration = NULL;
/* Tear down the device itself *after* destroy_device() - * has had a chance to interoogate it. */ + * has had a chance to interrogate it. */ free(controller->devices[devno]); controller->devices[devno] = NULL; } diff --git a/payloads/libpayload/drivers/usb/usbhub.c b/payloads/libpayload/drivers/usb/usbhub.c index 87c5816..5c39eac 100644 --- a/payloads/libpayload/drivers/usb/usbhub.c +++ b/payloads/libpayload/drivers/usb/usbhub.c @@ -285,7 +285,7 @@ return; }
- /* Get number of ports from hub decriptor */ + /* Get number of ports from hub descriptor */ int type = is_usb_speed_ss(dev->speed) ? 0x2a : 0x29; /* similar enough */ hub_descriptor_t desc; /* won't fit the whole thing, we don't care */ if (get_descriptor(dev, gen_bmRequestType(device_to_host, class_type, diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c index d8b7bce..50fd24b 100755 --- a/payloads/libpayload/drivers/usb/usbmsc.c +++ b/payloads/libpayload/drivers/usb/usbmsc.c @@ -538,7 +538,7 @@ time_t start_time_secs; struct timeval tv; /* SCSI/ATA specs say we have to wait up to 30s, but most devices - * are ready much sooner. Use a 5 sec timeout to better accomodate + * are ready much sooner. Use a 5 sec timeout to better accommodate * devices which fail to respond. */ const int timeout_secs = 5;
@@ -569,7 +569,7 @@ MSC_INST (dev)->ready = USB_MSC_NOT_READY; }
- /* Don't bother spinning up the stroage device if the device is not + /* Don't bother spinning up the storage device if the device is not * ready. This can happen when empty card readers are present. * Polling will pick it back up if readiness changes. */ if (!MSC_INST (dev)->ready) diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index d346e4b..8cb984b8 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -509,7 +509,7 @@ * When d hits the right bottom corner, s0 also hits the right bottom * corner of the pixel array because that's how scale->x and scale->y * have been set. Since the pixel array size is already validated in - * parse_bitmap_header_v3, s0 is guranteed not to exceed pixel array + * parse_bitmap_header_v3, s0 is guaranteed not to exceed pixel array * boundary. */ struct vector s0, s1, d;
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38911/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/c/coreboot/+/38911/1/payloads/libpayload/drivers... PS1, Line 69: usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); line over 96 characters
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38911
to look at the new patch set (#2).
Change subject: payloads: Fix typos ......................................................................
payloads: Fix typos
Change-Id: Ib7f1ba1766e5c972542ce7571a8aa3583c513823 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M payloads/coreinfo/cpuinfo_module.c M payloads/libpayload/drivers/i8042/keyboard.c M payloads/libpayload/drivers/serial/ipq40xx.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/serial/qcs405.c M payloads/libpayload/drivers/udc/dwc2.c M payloads/libpayload/drivers/usb/dwc2.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/drivers/usb/usbhub.c M payloads/libpayload/drivers/usb/usbmsc.c M payloads/libpayload/drivers/video/graphics.c M payloads/libpayload/libc/args.c M payloads/libpayload/libc/malloc.c M payloads/libpayload/libc/readline.c M payloads/libpayload/libc/string.c 17 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38911/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 69: usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); line over 96 characters
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 352: ps/2 PS/2
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 356: parameters nit: 'params' is a common short form of 'parameters', not a typo. The complete form now fits in one line because of the increased 96 character width.
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/ipq40xx.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 553: For simplicity sake Missing a `'s` and a comma:
For simplicity's sake, let's rely...
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/ipq806x.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 343: /* For simplicity sake let's rely on coreboot initializing the UART. */ Same as before
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 541: /* For simplicity sake let's rely on coreboot initializing the UART. */ Same as before
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/udc/dwc2.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 256: /*Already disabled*/ Please add spaces like on the other comments
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/libc/re... File payloads/libpayload/libc/readline.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/libc/re... PS2, Line 132: unprintable 'unprintables' was referring to 'unprintable characters'
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 2:
(7 comments)
Thx
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 352: ps/2
PS/2
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 356: parameters
nit: 'params' is a common short form of 'parameters', not a typo. […]
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/ipq40xx.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 553: For simplicity sake
Missing a `'s` and a comma: […]
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/ipq806x.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 343: /* For simplicity sake let's rely on coreboot initializing the UART. */
Same as before
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 541: /* For simplicity sake let's rely on coreboot initializing the UART. */
Same as before
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/udc/dwc2.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/drivers... PS2, Line 256: /*Already disabled*/
Please add spaces like on the other comments
Done
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/libc/re... File payloads/libpayload/libc/readline.c:
https://review.coreboot.org/c/coreboot/+/38911/2/payloads/libpayload/libc/re... PS2, Line 132: unprintable
'unprintables' was referring to 'unprintable characters'
Done
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38911
to look at the new patch set (#3).
Change subject: payloads: Fix typos ......................................................................
payloads: Fix typos
Change-Id: Ib7f1ba1766e5c972542ce7571a8aa3583c513823 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M payloads/coreinfo/cpuinfo_module.c M payloads/libpayload/drivers/i8042/keyboard.c M payloads/libpayload/drivers/serial/ipq40xx.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/serial/qcs405.c M payloads/libpayload/drivers/udc/dwc2.c M payloads/libpayload/drivers/usb/dwc2.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/drivers/usb/usbhub.c M payloads/libpayload/drivers/usb/usbmsc.c M payloads/libpayload/drivers/video/graphics.c M payloads/libpayload/libc/args.c M payloads/libpayload/libc/malloc.c M payloads/libpayload/libc/readline.c M payloads/libpayload/libc/string.c 17 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38911/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38911/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/c/coreboot/+/38911/3/payloads/libpayload/drivers... PS3, Line 69: usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38911/4/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/c/coreboot/+/38911/4/payloads/libpayload/drivers... PS4, Line 69: usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); line over 96 characters
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38911 )
Change subject: payloads: Fix typos ......................................................................
payloads: Fix typos
Change-Id: Ib7f1ba1766e5c972542ce7571a8aa3583c513823 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38911 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/coreinfo/cpuinfo_module.c M payloads/libpayload/drivers/i8042/keyboard.c M payloads/libpayload/drivers/serial/ipq40xx.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/serial/qcs405.c M payloads/libpayload/drivers/udc/dwc2.c M payloads/libpayload/drivers/usb/dwc2.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/drivers/usb/usbhub.c M payloads/libpayload/drivers/usb/usbmsc.c M payloads/libpayload/drivers/video/graphics.c M payloads/libpayload/libc/args.c M payloads/libpayload/libc/malloc.c M payloads/libpayload/libc/readline.c M payloads/libpayload/libc/string.c 17 files changed, 29 insertions(+), 29 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/coreinfo/cpuinfo_module.c b/payloads/coreinfo/cpuinfo_module.c index 94379f3..2b833a9 100644 --- a/payloads/coreinfo/cpuinfo_module.c +++ b/payloads/coreinfo/cpuinfo_module.c @@ -233,7 +233,7 @@ }
if (cpu_khz != 0) - mvwprintw(win, row++, 1, "CPU Speed: %d Mhz", cpu_khz / 1000); + mvwprintw(win, row++, 1, "CPU Speed: %d MHz", cpu_khz / 1000); else mvwprintw(win, row++, 1, "CPU Speed: Error");
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index 79455cf..f96f28a 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -349,7 +349,7 @@
/* * Set default parameters. - * Fix for broken QEMU ps/2 make scancodes. + * Fix for broken QEMU PS/2 make scancodes. */ ret = keyboard_cmd(I8042_KBCMD_SET_DEFAULT); if (!ret) { diff --git a/payloads/libpayload/drivers/serial/ipq40xx.c b/payloads/libpayload/drivers/serial/ipq40xx.c index 7656ad7..5a9079b 100644 --- a/payloads/libpayload/drivers/serial/ipq40xx.c +++ b/payloads/libpayload/drivers/serial/ipq40xx.c @@ -442,7 +442,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -550,7 +550,7 @@ static struct console_input_driver consin = {}; static struct console_output_driver consout = {};
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity's sake, let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/serial/ipq806x.c b/payloads/libpayload/drivers/serial/ipq806x.c index 183ada6..ef4ce80 100644 --- a/payloads/libpayload/drivers/serial/ipq806x.c +++ b/payloads/libpayload/drivers/serial/ipq806x.c @@ -235,7 +235,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ static unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -340,7 +340,7 @@ return byte; }
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity's sake, let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/serial/qcs405.c b/payloads/libpayload/drivers/serial/qcs405.c index 06ec5b9..1a7b9e9 100644 --- a/payloads/libpayload/drivers/serial/qcs405.c +++ b/payloads/libpayload/drivers/serial/qcs405.c @@ -434,7 +434,7 @@ }
/* - * msm_boot_uart_dm_init - initilaizes UART controller + * msm_boot_uart_dm_init - Initializes UART controller * @uart_dm_base: UART controller base address */ unsigned int msm_boot_uart_dm_init(void *uart_dm_base) @@ -538,7 +538,7 @@ return byte; }
-/* For simplicity sake let's rely on coreboot initalizing the UART. */ +/* For simplicity's sake, let's rely on coreboot initializing the UART. */ void serial_console_init(void) { struct cb_serial *sc_ptr = lib_sysinfo.serial; diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c index e95eb79..025c071 100644 --- a/payloads/libpayload/drivers/udc/dwc2.c +++ b/payloads/libpayload/drivers/udc/dwc2.c @@ -253,7 +253,7 @@
usb_debug("dwc2_halt_ep ep %d-%d\n", ep, in_dir); depctl.d32 = readl(&ep_reg->depctl); - /*Alread disabled*/ + /* Already disabled */ if (!depctl.epena) return; /* First step: disable EP */ @@ -558,7 +558,7 @@ writel(DXEPINT_AHBERR, &ep->ep_regs->depint); }
- /* Handle Setup Phase Done (Contorl Ep) */ + /* Handle Setup Phase Done (Control Ep) */ if (depint.setup) { usb_debug("DEPINT_SETUP\n"); writel(DXEPINT_SETUP, &ep->ep_regs->depint); diff --git a/payloads/libpayload/drivers/usb/dwc2.c b/payloads/libpayload/drivers/usb/dwc2.c index 963ae84..eef486b 100644 --- a/payloads/libpayload/drivers/usb/dwc2.c +++ b/payloads/libpayload/drivers/usb/dwc2.c @@ -233,7 +233,7 @@ packet_size = ep->maxpacketsize; packet_cnt = ALIGN_UP(size, packet_size) / packet_size; inpkt_length = packet_cnt * packet_size; - /* At least 1 packet should be programed */ + /* At least 1 packet should be programmed */ packet_cnt = (packet_cnt == 0) ? 1 : packet_cnt;
/* diff --git a/payloads/libpayload/drivers/usb/ehci.c b/payloads/libpayload/drivers/usb/ehci.c index 6876340..1cfa8bb 100644 --- a/payloads/libpayload/drivers/usb/ehci.c +++ b/payloads/libpayload/drivers/usb/ehci.c @@ -78,7 +78,7 @@ usb_debug("+===================================================+\n"); usb_debug("| ############# EHCI QH at [0x%08lx] ########### |\n", virt_to_phys(cur)); usb_debug("+---------------------------------------------------+\n"); - usb_debug("| Horizonal Link Pointer [0x%08lx] |\n", cur->horiz_link_ptr); + usb_debug("| Horizontal Link Pointer [0x%08lx] |\n", cur->horiz_link_ptr); usb_debug("+------------------[ 0x%08lx ]-------------------+\n", cur->epchar); usb_debug("| | Maximum Packet Length | [%04ld] |\n", ((cur->epchar & (0x7ffUL << 16)) >> 16)); usb_debug("| | Device Address | [%ld] |\n", cur->epchar & 0x7F); @@ -133,7 +133,7 @@ { short count = 0; ehci_stop(controller); - /* wait 10 ms just to be shure */ + /* wait 10 ms just to be sure */ mdelay(10); if (EHCI_INST(controller)->operation->usbsts & HC_OP_HC_HALTED) { EHCI_INST(controller)->operation->usbcmd = HC_OP_HC_RESET; @@ -215,7 +215,7 @@ total_len += page_len;
while (page_no < 5) { - /* we have a continguous mapping between virtual and physical memory */ + /* we have a contiguous mapping between virtual and physical memory */ page += 4096;
td->bufptrs[page_no++] = page; diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index f1dc081..2571273 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -66,7 +66,7 @@ usb_debug("|:| C | Condition Code | [%02ld] |:|\n", (cur->config & (0xFUL << 28)) >> 28); usb_debug("|:| O | Direction/PID | [%ld] |:|\n", (cur->config & (3UL << 19)) >> 19); usb_debug("|:| N | Buffer Rounding | [%ld] |:|\n", (cur->config & (1UL << 18)) >> 18); - usb_debug("|:| F | Delay Intterrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); + usb_debug("|:| F | Delay Interrupt | [%ld] |:|\n", (cur->config & (7UL << 21)) >> 21); usb_debug("|:| I | Data Toggle | [%ld] |:|\n", (cur->config & (3UL << 24)) >> 24); usb_debug("|:| G | Error Count | [%ld] |:|\n", (cur->config & (3UL << 26)) >> 26); usb_debug("|:+-----------------------------------------------+:|\n"); @@ -879,7 +879,7 @@ intrq_td_t *const td = INTRQ_TD_FROM_TD(done_td); intr_queue_t *const intrq = td->intrq; /* Check if the corresponding interrupt - queue is still beeing processed. */ + queue is still being processed. */ if (intrq->destroy) { /* Free this TD, and */ free(td); diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index 4004def..d98fd9e 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -499,7 +499,7 @@ break; }
- /* Gather up all endpoints belonging to this inteface */ + /* Gather up all endpoints belonging to this interface */ dev->num_endp = 1; for (; ptr + 2 <= end && ptr[0] && ptr + ptr[0] <= end; ptr += ptr[0]) { if (ptr[1] == DT_INTF || ptr[1] == DT_CFG || @@ -654,7 +654,7 @@ controller->devices[devno]->configuration = NULL;
/* Tear down the device itself *after* destroy_device() - * has had a chance to interoogate it. */ + * has had a chance to interrogate it. */ free(controller->devices[devno]); controller->devices[devno] = NULL; } diff --git a/payloads/libpayload/drivers/usb/usbhub.c b/payloads/libpayload/drivers/usb/usbhub.c index 87c5816..5c39eac 100644 --- a/payloads/libpayload/drivers/usb/usbhub.c +++ b/payloads/libpayload/drivers/usb/usbhub.c @@ -285,7 +285,7 @@ return; }
- /* Get number of ports from hub decriptor */ + /* Get number of ports from hub descriptor */ int type = is_usb_speed_ss(dev->speed) ? 0x2a : 0x29; /* similar enough */ hub_descriptor_t desc; /* won't fit the whole thing, we don't care */ if (get_descriptor(dev, gen_bmRequestType(device_to_host, class_type, diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c index d8b7bce..50fd24b 100755 --- a/payloads/libpayload/drivers/usb/usbmsc.c +++ b/payloads/libpayload/drivers/usb/usbmsc.c @@ -538,7 +538,7 @@ time_t start_time_secs; struct timeval tv; /* SCSI/ATA specs say we have to wait up to 30s, but most devices - * are ready much sooner. Use a 5 sec timeout to better accomodate + * are ready much sooner. Use a 5 sec timeout to better accommodate * devices which fail to respond. */ const int timeout_secs = 5;
@@ -569,7 +569,7 @@ MSC_INST (dev)->ready = USB_MSC_NOT_READY; }
- /* Don't bother spinning up the stroage device if the device is not + /* Don't bother spinning up the storage device if the device is not * ready. This can happen when empty card readers are present. * Polling will pick it back up if readiness changes. */ if (!MSC_INST (dev)->ready) diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index d346e4b..8cb984b8 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -509,7 +509,7 @@ * When d hits the right bottom corner, s0 also hits the right bottom * corner of the pixel array because that's how scale->x and scale->y * have been set. Since the pixel array size is already validated in - * parse_bitmap_header_v3, s0 is guranteed not to exceed pixel array + * parse_bitmap_header_v3, s0 is guaranteed not to exceed pixel array * boundary. */ struct vector s0, s1, d; diff --git a/payloads/libpayload/libc/args.c b/payloads/libpayload/libc/args.c index 663d767..3839c62 100644 --- a/payloads/libpayload/libc/args.c +++ b/payloads/libpayload/libc/args.c @@ -52,7 +52,7 @@ * * @param caller to be used as argv[0] (may be NULL to ignore) * @param string to process - * @return 0 if no error occured. + * @return 0 if no error occurred. */ int string_to_args(char *caller, char *string) { @@ -66,7 +66,7 @@
/* Terminate if the string ends */ while (string && *string) { - /* whitespace occured? */ + /* whitespace occurred? */ if ((*string == ' ') || (*string == '\t')) { /* skip all whitespace (and null it) */ while (*string == ' ' || *string == '\t') diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 5107589..1fdb59e 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -318,7 +318,7 @@
struct align_region_t { - /* If alignment is 0 then the region reqpresents a large region which + /* If alignment is 0 then the region represents a large region which * has no metadata for tracking subelements. */ int alignment; /* start in memory, and size in bytes */ diff --git a/payloads/libpayload/libc/readline.c b/payloads/libpayload/libc/readline.c index 9387e091..7324e04 100644 --- a/payloads/libpayload/libc/readline.c +++ b/payloads/libpayload/libc/readline.c @@ -129,7 +129,7 @@ if (ch < 0x20) break;
- /* ignore unprintables */ + /* ignore unprintable characters */ if (ch >= 0x7f) break;
diff --git a/payloads/libpayload/libc/string.c b/payloads/libpayload/libc/string.c index 0e34a03..9309223 100644 --- a/payloads/libpayload/libc/string.c +++ b/payloads/libpayload/libc/string.c @@ -268,7 +268,7 @@ * * @param s The string. * @param c The character. - * @return A pointer to the first occurence of the character in the + * @return A pointer to the first occurrence of the character in the * string, or NULL if the character was not encountered within the string. */ char *strchr(const char *s, int c) @@ -288,7 +288,7 @@ * * @param s The string. * @param c The character. - * @return A pointer to the last occurence of the character in the + * @return A pointer to the last occurrence of the character in the * string, or NULL if the character was not encountered within the string. */
@@ -327,7 +327,7 @@ * * @param h The haystack string. * @param n The needle string (substring). - * @return A pointer to the first occurence of the substring in + * @return A pointer to the first occurrence of the substring in * the string, or NULL if the substring was not encountered within the string. */ char *strstr(const char *h, const char *n)
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)