Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63541 )
Change subject: arch/x86/postcar_loader: Correct off-by-one of MTRR end address in log
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63541/comment/ab6cbfff_d9451ef3
PS2, Line 12: wrong
Thanks Angel. […]
@Werner Thanks!
@Subrata Yes, I understand the motivation behind this change and I agree it's reasonable, but it doesn't correct or fix anything. Originally, the start was inclusive and the end was exclusive, and this change makes both inclusive. I am requesting two things:
1. Update the commit message so that it doesn't say this commit fixes/corrects something. I think "to be consistent with how resource allocator code prints ranges" is a better reason.
2. Also update other files that print MTRR ranges, for the sake of consistency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ca292f9cf272564cb5ef1c4ea38f5c483605c94
Gerrit-Change-Number: 63541
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 18:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment