Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality ......................................................................
Patch Set 10: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... File src/soc/intel/fsp_broadwell_de/southcluster.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... PS10, Line 268: iio_hide(slot, func); I there a reason you have not passed in the *dev-pointer to iio_hide and deal with device and function number in iio_hide()? I am not against the chosen implementation, it would just be more obvious if you want to hide a device that you pass in the device pointer to the function that hides it. But I am fine.
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... File src/soc/intel/fsp_broadwell_de/ubox.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... PS10, Line 28: Once you have ubox.c you can move get_busno1() from vtd.h down here, maybe in a follow-up commit?
-
Werner Zeh (Code Review)