Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Kyösti Mälkki.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61215 )
Change subject: device: Add support for PCIe Resizable BARs
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/61215/comment/e2cfc67a_96a36f47
PS3, Line 643: in preference of
NIT - this reads a bit confusing. Maybe "in preference to" or "in preference over"?
https://review.coreboot.org/c/coreboot/+/61215/comment/603b91d5_5f7a88e2
PS3, Line 660: )
NIT - end with a period.
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/61215/comment/70c026c2_c3a195ed
PS3, Line 351: 4
Should this be assigned a shift value constant like those below (eg. line 373)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14fcbe0ef09fdc7f6061bcf7439d1160d3bc4abf
Gerrit-Change-Number: 61215
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 20:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment