Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Patrick Rudolph, David Guckian.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36607 )
Change subject: mb/teleplatforms/D4E4S16P8: Configure ast25xx bootstraps
......................................................................
Patch Set 14:
(4 comments)
Patchset:
PS11:
Please keep board specific changes inside mainboard part.
Done
File src/soc/intel/denverton_ns/chip.c:
https://review.coreboot.org/c/coreboot/+/36607/comment/697f2edd_1749b441
PS7, Line 73: /* Debug output, remove if it stalls here. */
: pci_dump_ast25xx_path();
:
: ast25xx_probe();
:
: /* Debug output, remove if it stalls here. */
: pci_dump_ast25xx_path();
`ast25xx_probe()` can be called from mainboard code using `mainboard_ops`.
Done
File src/soc/intel/denverton_ns/chip.c:
https://review.coreboot.org/c/coreboot/+/36607/comment/6856bb5f_86431bad
PS11, Line 51: ast25xx_probe();
As it is board specific please move to mainboard part.
Done
File src/soc/intel/denverton_ns/include/soc/ramstage.h:
https://review.coreboot.org/c/coreboot/+/36607/comment/e49130f2_7ea0915f
PS11, Line 18: int ast25xx_probe(void);
As it is board specific please move to mainboard part.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92195969419f9c38845cb67f294fdab33fb481af
Gerrit-Change-Number: 36607
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: David Guckian
d.guckian20@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: David Guckian
d.guckian20@gmail.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 10:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mariusz Szafrański
mariuszx.szafranski@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: David Guckian
d.guckian20@gmail.com
Gerrit-MessageType: comment