Attention is currently required from: Angel Pons, Patrick Rudolph. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51633 )
Change subject: device/azalia_device.c: Move valid timeout delay to Kconfig ......................................................................
Patch Set 2:
(2 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/51633/comment/b71ae042_71be119d PS2, Line 166: * No response would imply that the code is non-operative. that the codec is non-operative?
https://review.coreboot.org/c/coreboot/+/51633/comment/707b0c0e_6c64a37d PS2, Line 183: stopwatch_init_usecs_expire(&sw, CONFIG_AZALIA_VALID_TIMEOUT_US); given that we already have the "standard" 25us timeout, I guess it's better named something like AZALIA_ASSUME_HUNG_AFTER_US or something like that?
-
Patrick Georgi (Code Review)