Attention is currently required from: Felix Singer, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60645 )
Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Old and new syntax was mixed before these patches. That is nothing new. Not speaking of the different spellings of the instructions, like LAnd, Land or land. Yes, ASL is case-insensitive and it's the same syntax, but it's a mess. So not many people care about that.
Well, do you expect reviewers to check if the file was a mess before? Or should we assume that everything is always a mess? IMO, it's attitude like yours why it sometimes looks messy.
Please note in the commit messages if the resulting byte code changes.
Not doable for such an amount of patches.
People have done so before, i.e. you're too lazy?
-
Nico Huber (Code Review)