Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri.
Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email )
Change subject: mb/asrock: Add Z87M OC Formula (Haswell)
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/asrock/z87m_oc_formula/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/82906/comment/3c7b0641_4c2ade36?usp... :
PS11, Line 14: 0x411111f0
This macro means the same thing as that raw hex value. For reference, see commit ca9f94854176 (mb/**/hda_verb: Use `AZALIA_PIN_CFG_NC(0)`)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746
Gerrit-Change-Number: 82906
Gerrit-PatchSet: 11
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 00:43:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com