Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68634 )
Change subject: mb/google/kahlee: use override devicetrees for variants ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/kahlee/variants/aleena/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68634/comment/179e21ad_f7f8f552 PS3, Line 85: device ref i2c_3 on : chip drivers/i2c/generic : register "hid" = ""RAYD0001"" : register "desc" = ""Raydium Touchscreen"" : register "probed" = "1" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" : register "reset_delay_ms" = "20" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" : register "enable_delay_ms" = "1" : register "has_power_resource" = "1" : device i2c 39 on end : end : chip drivers/i2c/generic : register "hid" = ""ELAN0001"" : register "desc" = ""ELAN Touchscreen"" : register "probed" = "1" : register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" : register "reset_delay_ms" = "20" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" : register "enable_delay_ms" = "1" : register "has_power_resource" = "1" : device i2c 10 on end : end : end
same here - the ELAN and Raydium touchscreens are common and can be moved to the baseboard
the raydium touchscreen on liara uses level irq while the others use edge irq. filed b:254698159 to have someone look at this
-
Felix Held (Code Review)