Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33756
Change subject: soc/amd/commom/hda: Add Picasso IDs ......................................................................
soc/amd/commom/hda: Add Picasso IDs
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I02b279a2b625ecbdf827cb4643d772eb81ddfe70 --- M src/soc/amd/common/block/hda/hda.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/33756/1
diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index f4ea732..49fc1a6 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -21,6 +21,8 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_SB900_HDA, PCI_DEVICE_ID_AMD_CZ_HDA, + PCI_DEVICE_ID_AMD_PCO_HDA0, + PCI_DEVICE_ID_AMD_PCO_HDA1, 0 };
Martin Roth has uploaded a new patch set (#2) to the change originally created by Marshall Dawson. ( https://review.coreboot.org/c/coreboot/+/33756 )
Change subject: soc/amd/common/hda: Add Picasso IDs ......................................................................
soc/amd/common/hda: Add Picasso IDs
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I02b279a2b625ecbdf827cb4643d772eb81ddfe70 --- M src/soc/amd/common/block/hda/hda.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/33756/2
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33756 )
Change subject: soc/amd/common/hda: Add Picasso IDs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33756/3/src/soc/amd/common/block/hda/hda.c File src/soc/amd/common/block/hda/hda.c:
https://review.coreboot.org/#/c/33756/3/src/soc/amd/common/block/hda/hda.c@2... PS3, Line 24: PCI_DEVICE_ID_AMD_PCO_HDA0, : PCI_DEVICE_ID_AMD_PCO_HDA1 Not yet defined. I downloaded this patch and did a search... they are used here, but defined nowhere.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33756 )
Change subject: soc/amd/common/hda: Add Picasso IDs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33756/3/src/soc/amd/common/block/hda/hda.c File src/soc/amd/common/block/hda/hda.c:
https://review.coreboot.org/#/c/33756/3/src/soc/amd/common/block/hda/hda.c@2... PS3, Line 24: PCI_DEVICE_ID_AMD_PCO_HDA0, : PCI_DEVICE_ID_AMD_PCO_HDA1
Not yet defined. I downloaded this patch and did a search... […]
Already in. https://review.coreboot.org/c/coreboot/+/33748
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33756 )
Change subject: soc/amd/common/hda: Add Picasso IDs ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33756 )
Change subject: soc/amd/common/hda: Add Picasso IDs ......................................................................
soc/amd/common/hda: Add Picasso IDs
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I02b279a2b625ecbdf827cb4643d772eb81ddfe70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33756 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/soc/amd/common/block/hda/hda.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Richard Spiegel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index f4ea732..49fc1a6 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -21,6 +21,8 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_SB900_HDA, PCI_DEVICE_ID_AMD_CZ_HDA, + PCI_DEVICE_ID_AMD_PCO_HDA0, + PCI_DEVICE_ID_AMD_PCO_HDA1, 0 };