Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84101?usp=email )
Change subject: util/hda-decoder: Protect 'fields' slice if empty string ......................................................................
util/hda-decoder: Protect 'fields' slice if empty string
This avoids panic if the file contains an empty string or an incorrect configuration:
goroutine 1 [running]: main.decodeFile({0x7ffd63da92a0?, 0xc000014070?}, 0x8?) /path/to/coreboot/util/hda-decoder/main.go:72 +0x2ef main.main() /path/to/coreboot/util/hda-decoder/main.go:158 +0x2a5
Change-Id: I9ae8544e52d82e8d8a82a88a85a2de7d2f295ec1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84101 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/hda-decoder/main.go 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/hda-decoder/main.go b/util/hda-decoder/main.go index 83ddcbb..d686f19 100644 --- a/util/hda-decoder/main.go +++ b/util/hda-decoder/main.go @@ -69,6 +69,11 @@
for scanner.Scan() { fields := strings.Fields(scanner.Text()) + if len(fields) != 2 { + fmt.Print("// Something went wrong\n") + continue + } + pin := stringToUint32(fields[0]) config := stringToUint32(fields[1])