Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60002 )
Change subject: mb/google/corsola: setup open-drain ChromeOS pins
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/corsola/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135244):
https://review.coreboot.org/c/coreboot/+/60002/comment/b1aa1794_2c0d9dbb
PS1, Line 25: #define GPIO_XHCI_DONE GPIO(PERIPHERAL_EN1)
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55a773bb63404a1b952f7e7645eb7aba6638b00
Gerrit-Change-Number: 60002
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 11:28:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment