Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76116?usp=email )
Change subject: mb/google/rex/var/rex0: Change touch over spi interrupt trigger to edge
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl:
https://review.coreboot.org/c/coreboot/+/76116/comment/86dc36dc_de0cd9af :
PS3, Line 42: Edge
For I2C mode, it's level. Wondering why level not working here.
It is mentioned in the hid over spi spec here: https://www.microsoft.com/en-us/download/details.aspx?id=103325:
"HID SPI peripheral must provide a dedicated falling (HIGH-TO-LOW) edge triggered interrupt line to indicate when data or status is ready. This interrupt line must be pulled HIGH by hardware otherwise, meeting both HOST and DEVICE electrical requirements"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76116?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78937af22df22d80a702477b6790a7aa40d782a4
Gerrit-Change-Number: 76116
Gerrit-PatchSet: 3
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 17:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment