Attention is currently required from: Jamie Chen, Furquan Shaikh, Henry Sun, Marco Chen, Nick Vaccaro, Sheng-Liang Pan.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56982 )
Change subject: mb/google/octopus: add CBI SKU RAM ID 5
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/octopus/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/56982/comment/cf3947f3_0b7c2378
PS2, Line 169: [5]
I believe index 5 was not assigned in the past to any memory configuration. Can you please confirm?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I922a518cffc4dac71caec68e6f7a55c6c5717438
Gerrit-Change-Number: 56982
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Aug 2021 15:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment