Attention is currently required from: Christian Walter, Angel Pons, Lean Sheng Tan.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68224 )
Change subject: mb/prodrive/atlas: Print HSID ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/prodrive/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/68224/comment/bc80f367_876618e9 PS1, Line 10: PAD_CFG_GPI(GPP_A8, NONE, RSMRST), /* HSID_0 */
We should probably configure the GPIOs early in bootblock, as in the future we might need to read th […]
I just saw they were already configured in early gpios... Therefore removed them from ramstage gpio table. Weirdly
File src/mainboard/prodrive/atlas/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68224/comment/0c42ce4f_3dd54096 PS1, Line 11: static void print_hsid(void)
We probably want to have a `uint8_t get_hsid()` function instead, in case we need to deal with revis […]
Done
https://review.coreboot.org/c/coreboot/+/68224/comment/93b9e77a_fab427e2 PS1, Line 14: <
This is not a shift! 😄 […]
Done
https://review.coreboot.org/c/coreboot/+/68224/comment/691558de_2202fdfb PS1, Line 17: 1
No need to restrict the print width, it may actually make bugs harder to diagnose.
Done
-
Maximilian Brune (Code Review)