Change in coreboot[master]: drivers/pc80/rtc: Make use of alt-century byte configurable - coreboot-gerrit

12 Jul 2021


      Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56214 )
Change subject: drivers/pc80/rtc: Make use of alt-century byte configurable
......................................................................
Patch Set 1:
(2 comments)
File src/drivers/pc80/rtc/Kconfig:
https://review.coreboot.org/c/coreboot/+/56214/comment/a5b0836b_8b07108f 
PS1, Line 11: OSs
...
nit: OSes
Done
File src/drivers/pc80/rtc/mc146818rtc.c:
https://review.coreboot.org/c/coreboot/+/56214/comment/343f461d_6ea16da9 
PS1, Line 235: 69
...
Where does this 69 come from? Maybe `< 70` would make it easier to associate it with 1970?
Hrmm, copied from Linux ;)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifba3d77120c2474393ac5e64faac1baeeb58c893
Gerrit-Change-Number: 56214
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 12 Jul 2021 16:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment