Subrata Banik has posted comments on this change. ( https://review.coreboot.org/25802 )
Change subject: [WIP] soc/intel/apollolake: Use bootblock common stage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/p... File src/soc/intel/apollolake/bootblock/pch.c:
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/bootblock/p... PS3, Line 89: if (IS_ENABLED(CONFIG_SOC_UART_DEBUG)) : pch_uart_init();
this should be removed
yes, as we are calling this from stage file.
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/include/soc... File src/soc/intel/apollolake/include/soc/pch.h:
https://review.coreboot.org/#/c/25802/3/src/soc/intel/apollolake/include/soc... PS3, Line 4: * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Google Inc. : * Copyright (C) 2017 Intel Corporation. its new file, only 1 copyright?