Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31551 )
Change subject: drivers/intel/fsp1_0: Use new memory clearing API ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/#/c/31551/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31551/8//COMMIT_MSG@10 PS8, Line 10: requested by security framework. Please add a blank line below.
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/Makefile.in... File src/drivers/intel/fsp1_0/Makefile.inc:
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/Makefile.in... PS8, Line 52: romstage-y += $(call strip_quotes,$(CONFIG_FSP_SRC_PATH)) Order it before ramstage?
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/fsp_util.c File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/fsp_util.c@... PS8, Line 84: STACK stack?
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/fsp_util.c@... PS8, Line 89: int64_t Why not size_t?
https://review.coreboot.org/#/c/31551/8/src/drivers/intel/fsp1_0/fsp_util.c@... PS8, Line 92: free free_range so it doesn’t collide with the keyword?
-
Paul Menzel (Code Review)