[S] Change in coreboot[master]: mb/clevo/tgl-u: Add missing includes - coreboot-gerrit

23 Oct 2022


      Attention is currently required from: Felix Singer, Elyes Haouas.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68701 )
Change subject: mb/clevo/tgl-u: Add missing includes
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68701/comment/cdda43f5_4201df9e 
PS1, Line 7: Clean up includes
...
Done
Well, IMO "Add missing includes" is not technically correct, since with missing includes that code wouldn't build. That's why my suggestion was "avoid indirect includes"
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51ab987420e592ac2f841c2d7761c0adcc43124e
Gerrit-Change-Number: 68701
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 23 Oct 2022 08:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr
Gerrit-MessageType: comment