[M] Change in coreboot[master]: drivers/phy/m88e1512: Provide functionality to customize LEDs

[Werner Zeh (Code Review)]

Attention is currently required from: Mario Scheithauer.

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )

Change subject: drivers/phy/m88e1512: Provide functionality to customize LEDs
......................................................................

Patch Set 6:

(2 comments)

File src/drivers/phy/m88e1512/chip.h:

https://review.coreboot.org/c/coreboot/+/69386/comment/71ba5021_c4ea32f6 
PS6, Line 10: INTn is brought out LED[2]
INTn can be routed to LED[2] pin

File src/drivers/phy/m88e1512/m88e1512.c:

https://review.coreboot.org/c/coreboot/+/69386/comment/36886f6c_e0bbfc86 
PS6, Line 34: /* Set INTn output to be brought out on LED[2]. */
            : 		page_reg = mdio_ops->read(parent, dev->path.pnp.device,
            : 				LED_TIMER_CTRL_REG);
            : 		setbits16(&page_reg, (config->irq_led_2_enable << 7));
            : 		mdio_ops->write(parent, dev->path.pnp.device, LED_TIMER_CTRL_REG,
            : 				page_reg);
This should be a separate setting as we need to keep cases in mind where a board can have connected the INTn pin differently. So instead dealing with it in the LED section I would prefer to handle it separately and make it configurable. Something like 'enable_int' as a config member maybe?