Attention is currently required from: Andrey Petrov, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76921/comment/4eccaeea_95df80af :
PS3, Line 15: bootloader
Wrong term?
https://review.coreboot.org/c/coreboot/+/76921/comment/3fa7f95a_187c01f6 :
PS3, Line 18: It also adds a
: new config (BMP_LOGO_TO_GOP_BLT) to ensure backward compatibility with
: older generation FSP.
Can’t this (the FSP version) be detected at runtime?
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
PS3:
How special is `efi_bmp_image_header`? Otherwise most of these functions (check, if the image is valid) could be common code in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76921?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I992b45d65374f09498ff0cab497f7091e1e7a350
Gerrit-Change-Number: 76921
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 12:45:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment