Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76022?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for AcousticNoiseMitigation dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for AcousticNoiseMitigation dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="AcousticNoiseMitigation" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I66ee50f561f90e4feee9d4986b61a425ca16b27e Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb M src/mainboard/google/hatch/variants/mushu/overridetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/protectli/vault_cml/devicetree.cb M src/mainboard/purism/librem_cnl/devicetree.cb M src/mainboard/system76/addw1/devicetree.cb M src/mainboard/system76/bonw14/devicetree.cb M src/mainboard/system76/cml-u/devicetree.cb M src/mainboard/system76/gaze15/devicetree.cb M src/mainboard/system76/oryp5/devicetree.cb M src/mainboard/system76/oryp6/devicetree.cb M src/mainboard/system76/whl-u/devicetree.cb 17 files changed, 17 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/76022/1
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb index 4accade..8e09cac 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb +++ b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb @@ -31,7 +31,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true #register "dmipwroptimize" = "1" #register "satapwroptimize" = "1"
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 208a3ef..6d58615 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -47,7 +47,7 @@ .psys_pmax = 140, }" register Device4Enable = true - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "0" diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 4eb2970..bfbf26e 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -20,7 +20,7 @@ }"
# VR Slew rate setting - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "FastPkgCRampDisableIa" = "1" diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 50f8dbf..9571969 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -16,7 +16,7 @@ }"
# VR Slew rate setting - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index a98651f..e0b9f11 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -20,7 +20,7 @@ }"
# VR Slew rate setting - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "FastPkgCRampDisableIa" = "1" diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 82ffb1c..73c4ec1 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -16,7 +16,7 @@ }"
# VR Slew rate setting - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index e49e7f7..4bb7815 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -36,7 +36,7 @@ .psys_pmax = 140, }" register Device4Enable = true - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "0" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 3e40a46..a1fccfd 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -33,7 +33,7 @@ register s0ix_enable = true register dptf_enable = true register "satapwroptimize" = "1" - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb index 1fbae49..13d2ca0 100644 --- a/src/mainboard/protectli/vault_cml/devicetree.cb +++ b/src/mainboard/protectli/vault_cml/devicetree.cb @@ -32,7 +32,7 @@ register PchHdaAudioLinkHda = true
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index ab58893..ef7ef40 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -9,7 +9,7 @@ # FSP Silicon (soc/intel/cannonlake/fsp_params.c)
# Acoustic Noise - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
register "FastPkgCRampDisableIa" = "1" register "FastPkgCRampDisableGt" = "1" diff --git a/src/mainboard/system76/addw1/devicetree.cb b/src/mainboard/system76/addw1/devicetree.cb index aac5d7b..00cc708 100644 --- a/src/mainboard/system76/addw1/devicetree.cb +++ b/src/mainboard/system76/addw1/devicetree.cb @@ -23,7 +23,7 @@
# FSP Silicon (soc/intel/cannonlake/fsp_params.c) # Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/bonw14/devicetree.cb b/src/mainboard/system76/bonw14/devicetree.cb index e72b0d7..870bbad 100644 --- a/src/mainboard/system76/bonw14/devicetree.cb +++ b/src/mainboard/system76/bonw14/devicetree.cb @@ -29,7 +29,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/cml-u/devicetree.cb b/src/mainboard/system76/cml-u/devicetree.cb index 9eb8fca..eee78e1 100644 --- a/src/mainboard/system76/cml-u/devicetree.cb +++ b/src/mainboard/system76/cml-u/devicetree.cb @@ -30,7 +30,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/gaze15/devicetree.cb b/src/mainboard/system76/gaze15/devicetree.cb index dad9c5f..777355c 100644 --- a/src/mainboard/system76/gaze15/devicetree.cb +++ b/src/mainboard/system76/gaze15/devicetree.cb @@ -23,7 +23,7 @@
# FSP Silicon (soc/intel/cannonlake/fsp_params.c) # Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/oryp5/devicetree.cb b/src/mainboard/system76/oryp5/devicetree.cb index 11a079a..ffecee2 100644 --- a/src/mainboard/system76/oryp5/devicetree.cb +++ b/src/mainboard/system76/oryp5/devicetree.cb @@ -30,7 +30,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/oryp6/devicetree.cb b/src/mainboard/system76/oryp6/devicetree.cb index 422e817..ecc4ffd 100644 --- a/src/mainboard/system76/oryp6/devicetree.cb +++ b/src/mainboard/system76/oryp6/devicetree.cb @@ -28,7 +28,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms diff --git a/src/mainboard/system76/whl-u/devicetree.cb b/src/mainboard/system76/whl-u/devicetree.cb index abb2f2f..68ec08f 100644 --- a/src/mainboard/system76/whl-u/devicetree.cb +++ b/src/mainboard/system76/whl-u/devicetree.cb @@ -30,7 +30,7 @@ }"
# Misc - register "AcousticNoiseMitigation" = "1" + register AcousticNoiseMitigation = true
# Power register "PchPmSlpS3MinAssert" = "3" # 50ms