Change in ...coreboot[master]: mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB"
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31526
Change subject: mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB" ......................................................................
mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB"
Error spotted using IASL 20190215: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I7da9dcd68f5eec6383de7370bc8ab35f96a90c06 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/roda/rk9/acpi/superio.asl 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31526/1
diff --git a/src/mainboard/roda/rk9/acpi/superio.asl b/src/mainboard/roda/rk9/acpi/superio.asl index e2faccc..d177609 100644 --- a/src/mainboard/roda/rk9/acpi/superio.asl +++ b/src/mainboard/roda/rk9/acpi/superio.asl @@ -280,11 +280,11 @@ }
CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IOA._MIN, IOMN) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IOB._MIN, IOMN) CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IOA._MAX, IOMX) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IOB._MAX, IOMX) CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IRA._INT, IRQ) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IRB._INT, IRQ)
/* I/O Base */ Store (READ(0, 0x25, 0xfe), Local0)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31526 )
Change subject: mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB" ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31526 )
Change subject: mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB" ......................................................................
mb/roda/rk9/acpi/superio.asl: Fix copy-paste error on "COMB"
Error spotted using IASL 20190215: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I7da9dcd68f5eec6383de7370bc8ab35f96a90c06 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/31526 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/roda/rk9/acpi/superio.asl 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/roda/rk9/acpi/superio.asl b/src/mainboard/roda/rk9/acpi/superio.asl index e2faccc..d177609 100644 --- a/src/mainboard/roda/rk9/acpi/superio.asl +++ b/src/mainboard/roda/rk9/acpi/superio.asl @@ -280,11 +280,11 @@ }
CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IOA._MIN, IOMN) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IOB._MIN, IOMN) CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IOA._MAX, IOMX) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IOB._MAX, IOMX) CreateWordField(RSRC, - _SB.PCI0.LPCB.SIO1.COMA._CRS._IRA._INT, IRQ) + _SB.PCI0.LPCB.SIO1.COMB._CRS._IRB._INT, IRQ)
/* I/O Base */ Store (READ(0, 0x25, 0xfe), Local0)
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)