Attention is currently required from: Anil Kumar K, Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79413?usp=email )
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
Patch Set 18: Code-Review+1
(3 comments)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/79413/comment/fbfd5cbf_386aa093 :
PS18, Line 237: SOC_INTEL_CSE_RW_UPDATE
should we use this as depends ?
It follows above configs. Should we update all?
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/79413/comment/480bd6e4_0a9fd657 :
PS18, Line 896: /* Read IFWI Build Version from CSE RW */
i thought we already had this data available as part of `cse_info_in_cbmem->cse_fwp_version. […]
That's different location info between CSE version and IFWI version. So we can't use cse_fwp_version.cur_cse_fw_version (read from CSE version info location) as it is.
https://review.coreboot.org/c/coreboot/+/79413/comment/c0843ebf_2d40a3fd :
PS18, Line 951: cse
It should be `ifwi version in cbfs`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 18
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Wed, 28 Feb 2024 20:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Gerrit-MessageType: comment