Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43860 )
Change subject: soc/intel/*: simplify XdciEnable code ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/43860/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43860/1//COMMIT_MSG@9 PS1, Line 9: simplyfied
simplified
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/cannonlake/fs... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/cannonlake/fs... PS1, Line 441: dev->enabled
potential null pointer dereference if `dev` is null
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/icelake/fsp_p... PS1, Line 167: PCH_DEVFN_USBOTG
on purpose, but I should mention this in commit msg
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/icelake/fsp_p... PS1, Line 168: dev->enabled
potential null pointer dereference if `dev` is null (even though the old code had the same problem)
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/jasperlake/fs... PS1, Line 207: dev->enabled
potential null pointer dereference if `dev` is null
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/skylake/chip.... PS1, Line 341: dev->enabled
potential null pointer dereference if `dev` is null
Done
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43860/1/src/soc/intel/tigerlake/fsp... PS1, Line 183: dev->enabled
potential null pointer dereference if `dev` is null
Done
-
Michael Niewöhner (Code Review)