[XL] Change in coreboot[main]: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC

[Name of user not set (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Shuo Liu, Vasiliy Khoruzhick.

[e-mail] has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )

Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................

Patch Set 28:

(8 comments)

File src/soc/intel/snowridge/acpi.c:

https://review.coreboot.org/c/coreboot/+/83321/comment/2af7753d_d1b9965c?usp... :
PS15, Line 97: {
> maybe the common codes could be used (src/acpi/acpigen_pci_root_resource_producer. […]

Now I use the common code to inject _CRS, _SEG and _BBN methods, but _STA method is inject manually.

https://review.coreboot.org/c/coreboot/+/83321/comment/38912620_1c5e6120?usp... :
PS15, Line 168: 	if (dev->path.type != DEVICE_PATH_DOMAIN ||
> could use domain0 checker here.

Done

https://review.coreboot.org/c/coreboot/+/83321/comment/73341199_7ae25c07?usp... :
PS15, Line 174: 	uncore_fill_ssdt();
> uncore usually indicates northcluster, a bit confusing here.

Done

https://review.coreboot.org/c/coreboot/+/83321/comment/d0f70850_8329054e?usp... :
PS15, Line 277: 		} else if (stack == STACK2) {
> there includes some hardcodings, not sure if this could improved in future. e.g. […]

I improved it by using coreboot device tree, all of the FSP hob related code is removed.

https://review.coreboot.org/c/coreboot/+/83321/comment/1c17dcc1_b9d5120b?usp... :
PS15, Line 430: 	if (dev->upstream->secondary) /**< Write only for system agent in the first domain 0. */
> could use the domain0 checker

Done

File src/soc/intel/snowridge/acpi/uncore.asl:

https://review.coreboot.org/c/coreboot/+/83321/comment/3d31ae9b_4e6b63ca?usp... :
PS17, Line 14: Scope (_SB.PC00) {
> can you put this to dsdt. […]

I changed the hierarchy to the following:
```
dsdt.asl
|
|____uncore.asl
|    |
|    |____pci_irq.asl
|
|____southcluster.asl
     |____pch_irq.asl
     |____hostbridges.asl
```

File src/soc/intel/snowridge/chip.c:

https://review.coreboot.org/c/coreboot/+/83321/comment/f64611ca_aa730479?usp... :
PS15, Line 55: 	const BL_IIO_UDS *hob;
> Could you please follow C99 practice that declaring variable when using?

Done

https://review.coreboot.org/c/coreboot/+/83321/comment/9d25ac4c_472422fb?usp... :
PS15, Line 220: 			continue;
> we can use dev_find_path

Done